WIP: Update to latest structopt #22
Conversation
This commit marks the beginning of `git rebase` that will pull all the new comments that were made after the first import. The goal here is to only pull the comments keeping their respective authors and prioritizing `structopt`'s codebase on merge conflicts.
|
Hm, it seems certain commits are missing. Interesting... OK, only one commit is missing, and it's mine. I don't care, actually, so it's fine. |
|
OK guys, sorry for the radio silence, I got caught up in other projects and this one had mostly been blocked on TeXitoi/structopt#278 . I'll get to the work tomorrow, now I'm going to take a short break and play video games :) |
There was a typo preventing the probematic attr to be shown to the user.
was found in comments and code, but required no user-facing API change.
This adds a feature that can be turned on that will include the ParseArgs impl when generating the struct and enums
ref pull #191
|
What! You just replaced this package with structopt. |
|
@pksunkara Yes, this is the intention. Now I'm going to rework it a bit so it has the same API as And no, I didn't forget about it, I just got lost in other stuff (and nobody tried to ping me anyway). I'll finish the work in a week or so. |
|
I will review it once this is ready. Even though I can't merge it. |
|
Looking at this, it looks like the rebase wasn't done properly. If we resolve the conflicts every commit (since there are only 25, it should be simple), then we don't need to make it this complex. Can you tell me the commits where structopt is completely in clap? |
I was thinking the same, initially, but I changed my mind. Now it's about 100 extra commits, the difference it pretty damn huge (
He-he-he, take a closer look 😄
Could you please elaborate? I don't get what you mean. |
If I want to start porting structopt changes to clap, from which commit in structopt should I start? |
|
TeXitoi/structopt@30da80c is the answer to my question. |
This is pretty useless question if you ask me. You don't really need to know the branching point, leave that for git to figure out! This is how I did it: git clone https://github.com/clap-rs/clap_derive
cd clap_derive
git remote add --mirror=fetch structopt https://github.com/TeXitoi/structopt/
git fetch structopt master
git co FETCH_HEAD
git rebase master
# resolve a LOT of merge conflicts ...
git co -b update_to_latest_structopt |
|
I am almost done porting the changes from structopt. Will make a PR soon. |
|
Closing in favor of #23 |
Fixes #17
This is import of structopt v0.3 crate.
This is purely work-in-progress, the job now is to make all the necessary changes to adapt this to
clap0.3.