Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart agent winprocess #430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Smart agent winprocess #430

wants to merge 2 commits into from

Conversation

nicolasvion
Copy link
Contributor

Adding a way to monitor windows process throught signalfx.

Example SFX Agent configuration telegraf/win_services section :

    - type: telegraf/win_services
      serviceNames:
        - W3SVC
        - Tomcat8.5.11

pdecat
pdecat reviewed Jul 21, 2022
View reviewed changes
modules/smart-agent_winprocess/conf/readme.yaml
@@ -0,0 +1,3 @@
documentations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to documentation: https://github.com/signalfx/integrations/blob/master/signalfx-agent/agent_docs/monitors/telegraf-win_services.md

modules/smart-agent_winprocess/conf/01-winprocess.yaml
@@ -0,0 +1,15 @@
module: winprocess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name this detector win-services to match the underlying win_services metric that is used.

And maybe also rename the module `win-services if it is intended to only monitor Windows Services.

@pdecat pdecat added the detectors About nex or existing detectors label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdecat pdecat pdecat left review comments

@Shr3ps Shr3ps Awaiting requested review from Shr3ps Shr3ps is a code owner

@BzSpi BzSpi Awaiting requested review from BzSpi BzSpi is a code owner

@cvauvarin cvauvarin Awaiting requested review from cvauvarin cvauvarin is a code owner

@tchernomax tchernomax Awaiting requested review from tchernomax tchernomax is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
detectors About nex or existing detectors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasvion @pdecat