Integration aws direct connect #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlsclaranet
requested review from
BzSpi,
cvauvarin,
haedri,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
haedri
requested changes
Nov 5, 2024
| @@ -0,0 +1,13 @@ | |||
| ## Example | |||
| module: aws-direct-connect | |||
There was a problem hiding this comment.
Use the same module name as the other files (and remove ## Example line)
There was a problem hiding this comment.
Thanks for the feedback, it corrected now. Can you check it plz ?
|
|
||
| transformation: false | ||
| aggregation: true | ||
| exclude_not_running_vm: true |
There was a problem hiding this comment.
Not needed, this is a cloud service, not running inside a VM
There was a problem hiding this comment.
Thanks for the feedback, it corrected now. Can you check it plz ?
|
Thanks for the feedback, it corrected now. Can you check it plz ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salut,
un nouveau detector pour surveiller une direct connect.
Est-ce conforme à vos attentes ?
Si vous voulez le voir en fonctionnement je l'ai mis là en test : https://hermes-lz2.signalfx.com/#/home
Et je configuré l'appel du module ici https://git.fr.clara.net/CMP-MGS7LU/internals/PRJ-W2FMUL/tf-sfx-monitoring/-/blob/main/signalfx-detectors/prod/direct_connect.tf?ref_type=heads
cordialement