Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component slots #35

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Component slots #35

merged 8 commits into from
Feb 12, 2024

Conversation

sroussey
Copy link
Contributor

Rebased to main and then added more slots and made them available to custom nodes.

@sroussey sroussey changed the base branch from component-slots to main February 10, 2024 21:08
@sroussey sroussey mentioned this pull request Feb 10, 2024
Open
@clarkmcc
Copy link
Owner

Is this ready for review? I didn't want to dive in if you're not happy with it yet, but I did see your reference comment on the other issue.

@sroussey sroussey marked this pull request as ready for review February 11, 2024 05:08
@sroussey
Copy link
Contributor Author

Yeah, it is working so far.

I have more ideas, but don't think I'll get to them for a while.

clarkmcc
clarkmcc requested changes Feb 11, 2024
View reviewed changes
Copy link
Owner

@clarkmcc clarkmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run prettier? There's a config already in the project.

lib/node-builder.tsx Outdated
Comment on lines 35 to 37
inputs: React.JSX.Element[]
outputs: React.JSX.Element[]
inputGroups: React.JSX.Element[]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use-case for distinguishing between inputs and inputGroups? Can they be safely treated as the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sure. I was really just replicated what you had. Not sure anyone would ever want to reverse them!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they need to be generated separately, but it sounds like they can safely just be combined into a single inputs slot

@clarkmcc clarkmcc mentioned this pull request Feb 11, 2024
Closed
@sroussey
Copy link
Contributor Author

Can you run prettier? There's a config already in the project.

Really? I've been going nuts without it since there is no .vscode folder for this project

@clarkmcc
Copy link
Owner

Yeah I don't use vscode but having the config in the project is fine with me. I do think there's a few IDE-agnostic config files all at the root including a prettier setup.

Thanks for running the formatter! Will take a final look at this tomorrow.

@clarkmcc clarkmcc merged commit 1c9c89a into clarkmcc:main Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkmcc clarkmcc clarkmcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sroussey @clarkmcc