-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sigma Delta ADC #2617
base: master
Are you sure you want to change the base?
Sigma Delta ADC #2617
Conversation
…piler into SigmaDeltaADC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I really like the clarity of the code + the documentation.
However, I do think we could do with less one time use functions, we could move some functionality to the respective components. I'll discuss more irl
) | ||
=> SNat n0 | ||
-- ^ ADC width | ||
-> SNat (n0 + n1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I determine this number?
-- ^ Accumulator width | ||
-- Has to be larger or equal to the ADC width, | ||
-- the OSR is equal to 2^(AccumulatorWidth - ADCwidth) | ||
-> SNat n2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I determine this number?
-- 1. feedback to the RC network: | ||
-- The R and C of the low pass network need to be chosen such that: | ||
-- RC inbetween 200 and 1000 x clk, where clk is the frequency of | ||
-- output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this too, should be at module level or function level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an optimal value? if so, how do we choose it?
Added a Sigma Delta ADC to Clash Cores
Still TODO: