Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mergify config #2797

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update mergify config #2797

wants to merge 2 commits into from

Conversation

leonschoorl
Copy link
Member

It was reporting:

The configuration uses the deprecated update_method attribute of the queue action in one or more pull_request_rules. It must now be used under the queue_rules configuration.
A brownout is planned on August 26th, 2024.
This option will be removed on September 23rd, 2024.
For more information: https://docs.mergify.com/configuration/file-format/#queue-rules

It was reporting:
    The configuration uses the deprecated update_method attribute of the queue action in one or more pull_request_rules. It must now be used under the queue_rules configuration.
    A brownout is planned on August 26th, 2024.
    This option will be removed on September 23rd, 2024.
    For more information: https://docs.mergify.com/configuration/file-format/#queue-rules
@leonschoorl
Copy link
Member Author

I'm unsure whether this is right, or it should be something like:

...

queue_rules:
  - name: backport patches to 1.2
    update_method: rebase
  - name: backport patches to 1.4
    update_method: rebase
  - name: backport patches to 1.6
    update_method: rebase
  - name: backport patches to 1.8
    update_method: rebase

Or if we even need this at all.
The volume of backports typically isn't very high, so merge queue feel like unnecessary complexity.

Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it took me a couple of tries to get the config correct too, and there is no great way of testing bar making a separate repo. So I think we can just merge and try it out.

@leonschoorl
Copy link
Member Author

leonschoorl commented Aug 28, 2024

Apparently the deadline was extended

A brownout is planned on September 16th, 2024.
This option will be removed on October 21st, 2024.

@martijnbastiaan
Copy link
Member

Let's merge anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants