Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional VCD tracing #41

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add optional VCD tracing #41

merged 1 commit into from
Dec 4, 2024

Conversation

martijnbastiaan
Copy link
Member

No description provided.

@@ -104,7 +104,7 @@ runTest ::
FilePath ->
TestTree
runTest name mode n elfPath expectPath =
testCase ("Integration test `" <> name <> "` (" <> mode <> ")") $ do
testCase ("Integration test " <> name <> " (" <> mode <> ")") $ do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this so I can filter this test out with -p. If there are backticks / quotes in there I'd have to use non-obvious escaping (at the very least \ doesn't work..).

Copy link
Contributor

@hydrolarus hydrolarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall! Just some style things and one or two questions

clash-vexriscv/src/VexRiscv.hs Outdated Show resolved Hide resolved
clash-vexriscv/src/ffi/impl.cpp Outdated Show resolved Hide resolved
clash-vexriscv/src/ffi/impl.cpp Outdated Show resolved Hide resolved
clash-vexriscv/src/ffi/impl.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@hydrolarus hydrolarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Member

@lmbollen lmbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but pls make API nice

@martijnbastiaan martijnbastiaan merged commit 2eced42 into main Dec 4, 2024
8 checks passed
@martijnbastiaan martijnbastiaan deleted the add-vcd-tracing branch December 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants