-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional VCD tracing #41
Conversation
@@ -104,7 +104,7 @@ runTest :: | |||
FilePath -> | |||
TestTree | |||
runTest name mode n elfPath expectPath = | |||
testCase ("Integration test `" <> name <> "` (" <> mode <> ")") $ do | |||
testCase ("Integration test " <> name <> " (" <> mode <> ")") $ do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this so I can filter this test out with -p
. If there are backticks / quotes in there I'd have to use non-obvious escaping (at the very least \
doesn't work..).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall! Just some style things and one or two questions
d4a9694
to
68f0804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but pls make API nice
68f0804
to
3c98407
Compare
No description provided.