fix(docs): missing export env vars in capi proxmox sample #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
prometherion
requested changes
Sep 26, 2025
| ```bash | ||
| # The Proxmox VE host | ||
| export PROXMOX_URL="https://pve.example:8006" | ||
| export PROXMOX_URL='https://pve.example:8006 |
There was a problem hiding this comment.
Suggested change
| export PROXMOX_URL='https://pve.example:8006 | |
| export PROXMOX_URL="https://pve.example:8006" |
| # The Proxmox VE TokenID for authentication | ||
| export PROXMOX_TOKEN="clastix@pam\!capi" | ||
| export PROXMOX_TOKEN='clastix@pam\!capi' |
There was a problem hiding this comment.
Suggested change
| export PROXMOX_TOKEN='clastix@pam\!capi' | |
| export PROXMOX_TOKEN="clastix@pam\!capi" |
There was a problem hiding this comment.
In bash, with double quotes ("), the backslash escapes the exclamation mark, so the value would be clastix@pam!capi without the backslash. However, clusterctl traslates it as clastix@pam\!capi resulting in wrong token. So the correct is use single quote (') to preserve the entire string and without backslash export PROXMOX_TOKEN='clastix@pam!capi'.
| # The secret associated with the TokenID | ||
| export PROXMOX_SECRET="REDACTED" | ||
| export PROXMOX_SECRET='REDACTED' |
There was a problem hiding this comment.
Suggested change
| export PROXMOX_SECRET='REDACTED' | |
| export PROXMOX_SECRET="REDACTED" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #970