Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite #1

Merged
merged 141 commits into from
May 17, 2024
Merged

Add test suite #1

merged 141 commits into from
May 17, 2024

Conversation

claucambra
Copy link
Owner

No description provided.

@claucambra claucambra self-assigned this May 17, 2024
This reverts commit 04cbc1f.

Revert "Add conformance to RemoteFileMetadata in NKFile"

This reverts commit e15869b.

Revert "Add RemoteFileMetadata protocol"

This reverts commit 33c9d4f.

Revert "Add convenience extension to convert request options to NKRequestOptions"

This reverts commit 97fec94.

Revert "Add RemoteRequestOptions struct"

This reverts commit 9722a35.

Revert "Use remote error type enum in NKError extension"

This reverts commit 2e86d42.

Revert "Add remote error type enum"

This reverts commit d93ed04.

Kill off non NK types and errors and rely on the core library, the abstractions are not providing value
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@claucambra claucambra merged commit fa8bee3 into main May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants