Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/improved websocket handling #3

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

claucambra
Copy link
Owner

Start all ping requests as detached tasks that can be cancelled when necessary, preventing locking and other nasty things from happening

@claucambra claucambra self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.22%. Comparing base (d63580c) to head (5902576).

Files Patch % Lines
...ProviderKit/Enumeration/RemoteChangeObserver.swift 96.29% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   74.88%   75.22%   +0.33%     
==========================================
  Files          36       36              
  Lines        5937     5993      +56     
==========================================
+ Hits         4446     4508      +62     
+ Misses       1491     1485       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claucambra claucambra merged commit b0eddd1 into main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants