Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added throw error if no account is chosen #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

softwarecurator
Copy link

This is handy when user doesn't choose an account and cancels the connection so web apps can handle error correctly rather than just a console warning

@nico-herrera
Copy link

OMG THIS IS SO NEEDED

@clbrge
Copy link
Owner

clbrge commented Feb 19, 2022

One problem i see with your PR is that we remove warning even when the provider is not compliant.
Ideally this whole block should disappear when all provider would upgrade and respect the specs.
I would keep the warning and why not throw another error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants