Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a min size of 1 to avoid zero width/length in resize #250

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

sanjanag
Copy link
Member

@sanjanag sanjanag commented Jan 31, 2024

Avoids zero division in Image.resize() call of blurry check. This is caused by extreme odd aspect ratios present in the dataset. Assigned a min value of 1 to width/height if they are less than 1.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53ee321) 95.93% compared to head (def9db2) 96.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   95.93%   96.24%   +0.30%     
==========================================
  Files          16       16              
  Lines         985      985              
  Branches      194      194              
==========================================
+ Hits          945      948       +3     
+ Misses         20       18       -2     
+ Partials       20       19       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjanag sanjanag marked this pull request as ready for review February 1, 2024 07:13
@sanjanag sanjanag requested a review from jwmueller February 1, 2024 07:13
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanjanag sanjanag merged commit 4b4932d into cleanlab:main Feb 1, 2024
24 checks passed
@sanjanag sanjanag deleted the zero-edge-resize branch February 1, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants