Fix OAuthenticator reply parsing.

[gooseensky]

Provide QByteArray instead of QIODevice to QJson parser.
Bug link: flavio/qjson#52

[gooseensky]

Probably will fix #5457

[hatstand]

If this really fixes things, then I'd like to know why because we have this pattern everywhere.

[gooseensky]

This pattern is correct, but there is a regression in libqjson, which was introduced between 0.8.1 and 0.9.0 releases (flavio/qjson@774c778 - break commit, if someone is interested).

[gooseensky]

I've updated all problem places in code. It resolves issues with loggin into Google Drive and Dropbox, for example.

[hatstand]

We should rely on the upstream fix I think and perhaps check for QJson > 0.9.0 at compile time.

[gooseensky]

@hatstand But clementine use shared version of qjson, so compile time check wouldn't solve the problem.
Could we temporary add qjson to project's repo as 3rd party and build it as static library with correct behavior (I've already proposed a pull request with fix to qjson project, so we could take it or previously non-broken version).
When qjson version with fixed behavior will be released, we will drop dependency from repo.

[hatstand]

I realise it's not perfect but it's best if we can avoid adding more things to 3rdparty. Perhaps we can add a wrapper function for now that we use everywhere.

The best thing to do would be to harass distros into updating their qjson for the bugfix.

[abika]

This bug in QJson also breaks fetching tags from Musicbrainz.
How about using the JSON support build-in in Qt? It came with 5.0 which is 4 years old now. We could remove QJson everywhere.

[abika]

Nevermind, Clementine is still using Qt4.

Well, I can help if somebody decides how to solve this (globally).