Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstarts #1626

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Update quickstarts #1626

merged 11 commits into from
Oct 28, 2024

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Oct 11, 2024

Important

🔎 Previews:

Explanation:

This PR:

@alexisintech alexisintech marked this pull request as ready for review October 21, 2024 22:09
@alexisintech alexisintech requested a review from a team as a code owner October 21, 2024 22:09
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1626

@alexisintech alexisintech changed the title WIP - Update quickstarts Update quickstarts Oct 24, 2024

1. Create a `middleware.ts` file.
- If you're using the `/src` directory, place `middleware.ts` in the `/src` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, I prefer put or create vs. `place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good call

docs/quickstarts/astro.mdx Show resolved Hide resolved
docs/quickstarts/astro.mdx Outdated Show resolved Hide resolved
docs/quickstarts/astro.mdx Outdated Show resolved Hide resolved
docs/quickstarts/astro.mdx Outdated Show resolved Hide resolved
docs/quickstarts/expo.mdx Outdated Show resolved Hide resolved
docs/quickstarts/nextjs.mdx Outdated Show resolved Hide resolved
docs/quickstarts/tanstack-start.mdx Outdated Show resolved Hide resolved
docs/quickstarts/remix.mdx Outdated Show resolved Hide resolved
docs/quickstarts/nextjs.mdx Outdated Show resolved Hide resolved
docs/quickstarts/react.mdx Outdated Show resolved Hide resolved
@victoriaxyz victoriaxyz requested a review from a team as a code owner October 28, 2024 16:07
@mwickett
Copy link
Contributor

From the diff this looks like an overall simplification of the language we're using, is that correct? Any other changes? I'd like to reflect this in the Dashboard quickstarts as well so just wanted to confirm what the intention behind this is.

@alexisintech
Copy link
Member Author

From the diff this looks like an overall simplification of the language we're using, is that correct? Any other changes? I'd like to reflect this in the Dashboard quickstarts as well so just wanted to confirm what the intention behind this is.

Yes, so we are getting the quickstarts aligned in organization and with copy patterns.
We need to do further updates to the Expo quickstart, and the other Expo docs, but we'll do that in a separate PR. So this is it for now!

@alexisintech alexisintech merged commit 01dd427 into main Oct 28, 2024
4 checks passed
@alexisintech alexisintech deleted the aa/DOCS-9383 branch October 28, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants