Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add js backend sdk guide, deprecated warnings, comments to refactor code #1654

Merged
merged 4 commits into from
Oct 25, 2024
Merged

add js backend sdk guide, deprecated warnings, comments to refactor code #1654

merged 4 commits into from
Oct 25, 2024

Conversation

victoriaxyz
Copy link
Contributor

@victoriaxyz victoriaxyz commented Oct 25, 2024 •
edited
Loading

Important

🔎 Previews:

Explanation:

This PR:

  • adds deprecated warning
  • adds comments to refactor code snippets

Notes

  • test the examples in the new handling doc

@github-actions GitHub Actions
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1654

@victoriaxyz victoriaxyz changed the title Vi/docs 9429/deprecate node add deprecated warning to pages and comments to refactor code Oct 25, 2024
@victoriaxyz victoriaxyz marked this pull request as ready for review October 25, 2024 16:28
@victoriaxyz victoriaxyz requested a review from a team as a code owner October 25, 2024 16:28
@victoriaxyz victoriaxyz requested a review from royanger October 25, 2024 16:28
@victoriaxyz victoriaxyz changed the title add deprecated warning to pages and comments to refactor code add deprecated warnings to pages and comments to refactor code Oct 25, 2024
royanger
royanger approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@royanger royanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@victoriaxyz victoriaxyz changed the title add deprecated warnings to pages and comments to refactor code add js backend request guide, deprecated warnings, comments to refactor code Oct 25, 2024
@victoriaxyz victoriaxyz changed the title add js backend request guide, deprecated warnings, comments to refactor code add js backend sdk guide, deprecated warnings, comments to refactor code Oct 25, 2024
@alexisintech alexisintech merged commit 99dbb01 into main Oct 25, 2024
4 checks passed
@alexisintech alexisintech deleted the vi/docs-9429/deprecate-node branch October 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royanger royanger royanger approved these changes

Assignees
No one assigned
Labels
deploy-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victoriaxyz @royanger @alexisintech