You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(verify): open the PR as a draft until the evidence is in - #807
CodeRabbit reviews a pull request when it opens or turns ready, and its device evidence check judges the description it reads then. The skill had the agent open the PR ready and run attach right after, so the review could start before the evidence was written. On [BLACKSMITH TEST] fix(auth): shorten the phone field switcher label to "Use email or username" #805 the table landed 16 seconds after the PR opened, CodeRabbit had already read the earlier description, and the check failed until someone asked for a fresh review.
The skill now says to open the PR with gh pr create --draft, run attach and down, and run gh pr ready <n> once the description holds the evidence. For a remote session, where the evidence arrives about a minute after down, it says to check that gh pr view <n> --json body shows the verify-evidence block first. references/remote.md says the same.
team-review-request and code-owner-approval already run on ready_for_review, and local attach and the verify-attach workflow both publish to drafts, so nothing else changes.
In a Claude Code cloud session GitHub's GraphQL API is blocked, so gh pr create, gh pr view and gh pr ready fail there. The skill names the REST forms that work, including POST repos/<repo>/pulls/<n>/ccr/ready_for_review, which a cloud session on clerk/clerk-ios confirmed by flipping test PR [BLACKSMITH TEST] fix(auth): shorten the phone field switcher label to "Use email or username" #805 to draft and back. The wait for the evidence polls the description over REST for the table row and gives up after ten minutes.
Testing
Docs only. The next PR an agent opens with this skill shows whether CodeRabbit's first review passes the device evidence check.
Risk
Low: docs only. A PR stays a draft if an agent stops before gh pr ready, which is visible and easy to fix by hand.
CodeRabbit reviews a PR when it opens or turns ready and judges the
description it reads then. A PR opened ready was reviewed before attach
wrote the evidence, so its device evidence check failed (clerk-ios#805).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The iOS verification instructions now create a pull request as a draft before attaching device evidence. For remote sessions, they check for the verify-evidence table after down and mark the pull request ready after the table appears. The instructions document gh api alternatives for Claude Code cloud sessions and warn that review bots may review the description when the pull request opens or becomes ready.
clerk/clerk-ios#768: Adds the device-evidence check that the documented workflow references.
clerk/clerk-ios#777: Adds ready-event processing that occurs after the documented workflow marks the pull request ready.
Suggested reviewers: seanperez29
Merge Risk: Minimal · up to 06d05
The updated draft, polling, and readiness workflow has no concrete merge-blocking defect introduced by this PR.
Pre-merge checks: 6
Check name
Status
Explanation
Title check
The title "docs(verify): open the PR as a draft until the evidence is in" matches the main change. The PR changes the verify-clerk-ios skill and remote.md so agents open pull requests as drafts and ma…
Description check
The description covers the What and why section with context on the CodeRabbit timing problem and the citation of #805. It explains the workflow change, the remote session polling, and …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Testing, Risk, And Revert
The PR description contains all three required sections. Testing says the change is docs-only and identifies the next PR as validation. Risk states that the risk is a PR remaining a draft if the agent…
Device Evidence
PASS. The pull request changes only .claude/skills/verify-clerk-ios/SKILL.md and .claude/skills/verify-clerk-ios/references/remote.md. It changes no file under Sources/ClerkKit/, `Sources/ClerkK…
Full details: Title check
Explanation
The title "docs(verify): open the PR as a draft until the evidence is in" matches the main change. The PR changes the verify-clerk-ios skill and remote.md so agents open pull requests as drafts and mark them ready only after the device evidence table is in the description. The title is specific and concise, and it names the scope (verify) and the behavior change.
Full details: Description check
Explanation
The description covers the What and why section with context on the CodeRabbit timing problem and the citation of #805. It explains the workflow change, the remote session polling, and the GraphQL-blocked REST alternatives. The Testing, Risk, and How to revert sections are filled in with reasoning. The What to focus on section is omitted, which the template allows when the change is trivial. The Testing section does not name a simulator or screenshots, but the change is docs-only, so the template's screenshot requirement does not apply. Risk does not say whether the change touches protected paths, public API, or stored session data, and this is a minor gap. Overall the description is mostly complete.
Full details: Testing, Risk, And Revert
Explanation
The PR description contains all three required sections. Testing says the change is docs-only and identifies the next PR as validation. Risk states that the risk is a PR remaining a draft if the agent stops early. How to revert states that a plain revert is sufficient.
Full details: Device Evidence
Explanation
PASS. The pull request changes only .claude/skills/verify-clerk-ios/SKILL.md and .claude/skills/verify-clerk-ios/references/remote.md. It changes no file under Sources/ClerkKit/, Sources/ClerkKitUI/, or Examples/E2EHost/, so device evidence is not required.
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Automatic approval policy
Commit: 06d057043757.
Setting
Effective value
Source
Automatic approvals
Enabled
Global configuration
Merge risk
Moderate
Global configuration
Security risk
Not set
Global configuration
Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.
Limit details: You’ve used all 5 included reviews currently available. Your 57 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
… the cloud REST forms
In a Claude Code cloud session GitHub's GraphQL API is blocked, so gh pr
create, view and ready fail. Name the REST and CCR routes that work there,
and replace the eyeballed wait with a polling check that fails after ten
minutes instead of a fixed one-minute guess.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
What & why
attachright after, so the review could start before the evidence was written. On [BLACKSMITH TEST] fix(auth): shorten the phone field switcher label to "Use email or username" #805 the table landed 16 seconds after the PR opened, CodeRabbit had already read the earlier description, and the check failed until someone asked for a fresh review.gh pr create --draft, runattachanddown, and rungh pr ready <n>once the description holds the evidence. For a remote session, where the evidence arrives about a minute afterdown, it says to check thatgh pr view <n> --json bodyshows theverify-evidenceblock first.references/remote.mdsays the same.team-review-requestandcode-owner-approvalalready run onready_for_review, and localattachand theverify-attachworkflow both publish to drafts, so nothing else changes.gh pr create,gh pr viewandgh pr readyfail there. The skill names the REST forms that work, includingPOST repos/<repo>/pulls/<n>/ccr/ready_for_review, which a cloud session on clerk/clerk-ios confirmed by flipping test PR [BLACKSMITH TEST] fix(auth): shorten the phone field switcher label to "Use email or username" #805 to draft and back. The wait for the evidence polls the description over REST for the table row and gives up after ten minutes.Testing
Risk
gh pr ready, which is visible and easy to fix by hand.How to revert
🤖 Generated with Claude Code