Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(repo): Run CI workflow on pull_request_target #3514

Closed
wants to merge 1 commit into from

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jun 4, 2024

Description

Resolves SDK-1253

CI is failing (example) on some PRs from forked repositories due to repo secrets not being available.

Refer to the documentation for Using encrypted secrets in a workflow: "With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository."

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jun 4, 2024

⚠️ No Changeset found

Latest commit: ef44f2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LauraBeatris LauraBeatris self-assigned this Jun 4, 2024
@LauraBeatris LauraBeatris changed the title chore: Run CI workflow on pull_request_target ci(repo): Run CI workflow on pull_request_target Jun 4, 2024
@LauraBeatris
Copy link
Member Author

I'll close this as it seems we've already solved the case by triggering the workflows on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants