Skip to content

feat: Add missing German localization strings #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

vaihtovirta
Copy link
Contributor

Description

The PR adds missing localization strings for de-DE locale.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature (Localization updates)
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Sorry, something went wrong.

Copy link

vercel bot commented Apr 2, 2025

@vaihtovirta is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@LekoArts LekoArts self-assigned this Apr 2, 2025
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: dd12935

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 7:45am

Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Appreciate it 👍

Left some smaller comments and waiting on feedback from the team if we should translate "Billing", too

switchPlan: undefined,
billedAnnually: 'Jährlich abgerechnet',
free: 'Kostenlos',
getStarted: 'Loslegen',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
getStarted: 'Loslegen',
getStarted: 'Jetzt starten',

I think a more open interpretation is suitable here instead of the literal translation

blockButton__passkey: undefined,
subtitle: undefined,
title: undefined,
blockButton__passkey: 'Benutzen Sie Ihren Passkey',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
blockButton__passkey: 'Benutzen Sie Ihren Passkey',
blockButton__passkey: 'Verwenden Sie Ihren Passkey',

blockButton__passkey: 'Benutzen Sie Ihren Passkey',
subtitle:
'Die Verwendung Ihres Passkeys bestätigt Ihre Identität. Ihr Gerät kann nach Ihrem Fingerabdruck, Gesicht oder Bildschirmsperre fragen.',
title: 'Benutzen Sie Ihren Passkey',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'Benutzen Sie Ihren Passkey',
title: 'Verwenden Sie Ihren Passkey',

Let's keep things consistent

@@ -807,7 +813,7 @@ export const deDE: LocalizationResource = {
mobileButton__menu: 'Menü',
navbar: {
account: 'Profil',
billing: undefined,
billing: 'Billing',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: Ask team if we want to translate this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
billing: 'Billing',
billing: 'Abrechnung',

We can translate it 👍

@vaihtovirta
Copy link
Contributor Author

@LekoArts Thanks for your comments!
I've pushed the fixes and look forward to your further feedback.

@vaihtovirta vaihtovirta requested a review from LekoArts April 3, 2025 13:50
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nikosdouvlis nikosdouvlis merged commit 26ce4c1 into clerk:main Apr 7, 2025
1 of 2 checks passed
@vaihtovirta vaihtovirta deleted the feat-de-loc-strings branch April 7, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants