-
Notifications
You must be signed in to change notification settings - Fork 333
feat: Add missing German localization strings #5508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vaihtovirta is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: dd12935 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Appreciate it 👍
Left some smaller comments and waiting on feedback from the team if we should translate "Billing", too
packages/localizations/src/de-DE.ts
Outdated
switchPlan: undefined, | ||
billedAnnually: 'Jährlich abgerechnet', | ||
free: 'Kostenlos', | ||
getStarted: 'Loslegen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getStarted: 'Loslegen', | |
getStarted: 'Jetzt starten', |
I think a more open interpretation is suitable here instead of the literal translation
packages/localizations/src/de-DE.ts
Outdated
blockButton__passkey: undefined, | ||
subtitle: undefined, | ||
title: undefined, | ||
blockButton__passkey: 'Benutzen Sie Ihren Passkey', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockButton__passkey: 'Benutzen Sie Ihren Passkey', | |
blockButton__passkey: 'Verwenden Sie Ihren Passkey', |
packages/localizations/src/de-DE.ts
Outdated
blockButton__passkey: 'Benutzen Sie Ihren Passkey', | ||
subtitle: | ||
'Die Verwendung Ihres Passkeys bestätigt Ihre Identität. Ihr Gerät kann nach Ihrem Fingerabdruck, Gesicht oder Bildschirmsperre fragen.', | ||
title: 'Benutzen Sie Ihren Passkey', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: 'Benutzen Sie Ihren Passkey', | |
title: 'Verwenden Sie Ihren Passkey', |
Let's keep things consistent
packages/localizations/src/de-DE.ts
Outdated
@@ -807,7 +813,7 @@ export const deDE: LocalizationResource = { | |||
mobileButton__menu: 'Menü', | |||
navbar: { | |||
account: 'Profil', | |||
billing: undefined, | |||
billing: 'Billing', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: Ask team if we want to translate this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
billing: 'Billing', | |
billing: 'Abrechnung', |
We can translate it 👍
@LekoArts Thanks for your comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Description
The PR adds missing localization strings for
de-DE
locale.Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change