fix(integration): fix flaky keyless popover tests#7807
fix(integration): fix flaky keyless popover tests#7807jacekradko wants to merge 1 commit intomainfrom
Conversation
…ertions in keyless tests
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughTwo integration test files have been refactored to replace navigation-based verification with static href attribute checks. Instead of opening new pages and waiting for URL validation, the tests now directly inspect the href attributes of claim and claimed-keys links to verify they contain expected dashboard URLs and tokens. The changes remove cross-origin navigation patterns from the test execution flow. Inline comments were added to document the rationale for this approach. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
hrefattribute assertions in keyless popover integration testshrefattribute contains the correct dashboard URL and expected parametersTest plan
quickstart(chrome, 15) integration tests passquickstart(chrome, 16) integration tests passtanstack-react-start(chrome) integration tests passSummary by CodeRabbit