Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Commit

Permalink
Revert "grml-live: clean up MIRROR_DIRECTORY if provided."
Browse files Browse the repository at this point in the history
This reverts commit c78f58b.

While deleting the bind-mount destination of mirror directories is fine
in theory, we end up deleting empty base directories as well, which
is unexpected and unwanted behavior.

See grml#104 for the related
discussion, this issue needs further attention yet before we can
include this in a new release of grml-live.
  • Loading branch information
mika authored and clexanis committed Dec 12, 2022
1 parent 0d074d1 commit 600f8c9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions grml-live
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,7 @@ umount_all() {
fi

umount "${CHROOT_OUTPUT}/grml-live/sources/" 2>/dev/null || /bin/true
if [ -n "${MIRROR_DIRECTORY}" ]; then
umount "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
rmdir -p "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
fi
[ -n "$MIRROR_DIRECTORY" ] && umount "${CHROOT_OUTPUT}/${MIRROR_DIRECTORY}"
}
# }}}

Expand Down

0 comments on commit 600f8c9

Please sign in to comment.