bugfix for compile_settings #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
approved these changes
Jul 26, 2021
Isty001
requested changes
Jul 27, 2021
nouwaarom
force-pushed
the
enhancement/settings
branch
from
7ad3104
to
c3c9418
Compare
nouwaarom
force-pushed
the
enhancement/settings
branch
from
c3c9418
to
b486f2c
Compare
|
The tests fail on macOS, but this issue seems to have been there for a long time as the macOS tests haven't passed for previous builds as well. |
|
Yeah, it's probably related to #237 as it works fine for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to make the manifest names static. Therefore the variable was exposed by every unit that included the compile_settings, which caused the multiple definition errors when linking.