feat: Migrate to CPR SDK #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-c
force-pushed
the
feature/pods-1496-update-azure-pdf-parser-to-use-cpr-sdk
branch
3 times, most recently
from
ed473ff to
ba5cd7d
Compare
jesse-c
force-pushed
the
feature/pods-1496-update-azure-pdf-parser-to-use-cpr-sdk
branch
6 times, most recently
from
b969af1 to
0a180ab
Compare
jesse-c
commented
Jul 17, 2024
jesse-c
commented
Jul 17, 2024
jesse-c
commented
Jul 17, 2024
jesse-c
commented
Jul 17, 2024
THOR300
approved these changes
Jul 17, 2024
jesse-c
added a commit
to climatepolicyradar/navigator-document-parser
that referenced
this pull request
Jul 17, 2024
We're getting everything up to at least `3.10` [1][2]. [1] climatepolicyradar/azure-pdf-parser#87 (comment) [2] https://climate-policy-radar.slack.com/archives/C078S46DJFP/p1721219970276019
jesse-c
added a commit
to climatepolicyradar/navigator-document-parser
that referenced
this pull request
Jul 17, 2024
We're getting everything up to at least `3.10` [1][2]. [1] climatepolicyradar/azure-pdf-parser#87 (comment) [2] https://climate-policy-radar.slack.com/archives/C078S46DJFP/p1721219970276019
The data access library has been deprecated. It looks like this package isn't used directly in here. It is used in https://github.com/climatepolicyradar/navigator-document-parser [1][2], through a transitive dependency on this package. We don't lock the version locally, and our Poetry lock files are thus out-of-sync with this version. Relax it until we have a better approach. Don't try and install twice too. [1] https://github.com/climatepolicyradar/navigator-document-parser/blob/572fd0217abfdac81c83afcf61dbfdfcf5369ae1/poetry.lock#L273 [2] https://github.com/climatepolicyradar/navigator-document-parser/blob/572fd0217abfdac81c83afcf61dbfdfcf5369ae1/src/base.py#L6 test: Align test command
jesse-c
force-pushed
the
feature/pods-1496-update-azure-pdf-parser-to-use-cpr-sdk
branch
from
f566431 to
44d2921
Compare
jesse-c
deleted the
feature/pods-1496-update-azure-pdf-parser-to-use-cpr-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data access library has been deprecated.
update: CI was failing due to some caching issue (?) with a package. I've made another change that relaxes how Poetry is used, and have fixed that issue.
[1] https://github.com/climatepolicyradar/navigator-document-parser/blob/572fd0217abfdac81c83afcf61dbfdfcf5369ae1/poetry.lock#L273
[2] https://github.com/climatepolicyradar/navigator-document-parser/blob/572fd0217abfdac81c83afcf61dbfdfcf5369ae1/src/base.py#L6