DON'T MERGE swap weakAnd to userInput in YQL #142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaughter
reviewed
Nov 4, 2024
| family_description contains(@query_string), | ||
| text_block contains(@query_string) | ||
| ) | ||
| userInput(@query_string) |
There was a problem hiding this comment.
This might be something that I'm missing when looking at the docs, but I'm struggling to get my head around how userInput 'knows' which fields to look at, do you have a clearer understanding of this you could help me with?
There was a problem hiding this comment.
yes - i think it's the default fields specified in the schema
olaughter
approved these changes
Nov 4, 2024
| family_description contains(@query_string), | ||
| text_block contains(@query_string) | ||
| ) | ||
| userInput(@query_string) |
kdutia
changed the title
|
marking as don't merge as this seems to fail tests in the backend - see comment on linear ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a change to fix a seeming bug that wasn't detected until removing description embeddings from the YQL query and Vespa schema. Pushing this change first to check that it. works with the current schema, then i'll push changes to the schema and YQL to remove embedding search on descriptions.
The issue this aims to fix is that
weakAndseems to sometimes act like anAND, meaning that empty documents can be removed from search results even when they match on title or summary fields.UserInput docs for reference. This should also open us up to "i want to search this exact phrase" queries, which is supported by UserInput, so we'd just need to disable the nearestneighbour YQL clause in this case
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
No changes to tests, but current changes still pass locally.
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.