Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting the change to the Hit pydantic modelling. #185

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Feb 19, 2025

Description

Move the concept fields back to the base Hit object.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Unit tests.

@THOR300 THOR300 requested a review from a team as a code owner February 19, 2025 10:26
Copy link

linear bot commented Feb 19, 2025

@THOR300 THOR300 requested a review from jamesgorrie February 19, 2025 10:27
@THOR300
Copy link
Collaborator Author

THOR300 commented Feb 19, 2025

@jamesgorrie do you have any ideas for a unit test to avoid this happening again (backend or sdk)?

@THOR300 THOR300 merged commit 6669060 into main Feb 19, 2025
6 checks passed
@THOR300 THOR300 deleted the feature/pla-459-revert-pydantic-changes-to-the-sdk-around-concept-field branch February 19, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants