Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the 'I' selector to ruff config to sort imports #13

Closed
wants to merge 2 commits into from

Conversation

harrisonpim
Copy link
Contributor

@harrisonpim harrisonpim commented Dec 14, 2023

Ruff can sort imports by itself!

I've also trimmed the outer pyproject.toml and .pre-commit-config.yaml stuff as much as possible (I don't think we need to format any python within the template itself), while adding what we want to the corresponding files in {{ cookiecutter.repo_name }}.

Copy link

linear bot commented Dec 14, 2023

…ible, while the inner one should retain all the complexity
@harrisonpim harrisonpim requested a review from kdutia December 14, 2023 19:19
Copy link
Member

@kdutia kdutia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think we do want to keep formatting in the repo root, as we can make sure any boilerplate code we add to this is of good quality. Unless you're saying we can use the version in the template?

@kdutia
Copy link
Member

kdutia commented Dec 20, 2023

also, feel free to remove import sorting as i've had issues with it failing in CI despite passing locally too. i'm disabling it on other repos you've PRed and keeping the ruff-as-black-replacement stuff

@harrisonpim harrisonpim closed this Jan 8, 2024
@harrisonpim harrisonpim deleted the RND-687 branch January 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants