Skip to content

Commit

Permalink
Added pydantic to cpsell dict
Browse files Browse the repository at this point in the history
  • Loading branch information
katybaulch committed Sep 5, 2024
1 parent baa281c commit ab3271c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .trunk/configs/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"conftest",
"capsys",
"dtypes",
"isin"
"isin",
"pydantic"
],
"flagWords": ["hte"],
"suggestionsTimeout": 5000
Expand Down
2 changes: 2 additions & 0 deletions gcf_data_mapper/parsers/document.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ def contains_invalid_paths(urls: list[str]) -> bool:
def validate_urls(urls: list[str], doc_id: str) -> Optional[bool]:
"""Validate a list of URLs for empty, duplicate, & malformed entries.
TODO can we use Pydantic for this?
param: list[str] urls : A list of urls
param: str doc_id: The document id of the invalid source urls
raises ValueError: If the list contains duplicate, empty or,
Expand Down

0 comments on commit ab3271c

Please sign in to comment.