-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/pdct 1399 map document to new json structure #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pdct 1399 map document to new json structure #9
Conversation
- separate functionality for mapping translated files, checking validation etc - check for missing columns in the data frame
- add new column headers to titles - update validate function to check for invalid paths - small udpates for readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab!!! Couple of tiny changes and a question
rather than telling trunk to ignore potential mispellings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I think we need to revisit your conftest though. It's best practice to use mock data rather than actual data when writing tests & fixtures, as it helps isolate what's under test and remove external dependencies (in this case, the test data is the external dependency as we're using actual GCF data).
move fixtures into its own file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
What's changed?
Update the document function in the file that maps the data frame to the expected structure being a list of dictionaries with some denoted properties.
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x