Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move unnecessary requirements for API to new dependency group; fix dockerfile #67

Merged
merged 3 commits into from
May 2, 2024

Conversation

kdutia
Copy link
Member

@kdutia kdutia commented Apr 25, 2024

No description provided.

@kdutia kdutia marked this pull request as ready for review April 25, 2024 14:40
@kdutia kdutia requested a review from THOR300 April 29, 2024 07:49
@kdutia kdutia changed the title move unnecessary requirements for API to new dependency group move unnecessary requirements for API to new dependency group; fix dockerfile May 2, 2024
Copy link
Contributor

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just thinking it might be worth adding a quick ci test to just build the docker image to avoid this happening again!

@kdutia
Copy link
Member Author

kdutia commented May 2, 2024

@THOR300 i'm hoping we'll archive this repo asap and take down gst1 so maybe not worth it :D

@kdutia kdutia merged commit 0d0cd2d into main May 2, 2024
2 checks passed
@kdutia kdutia deleted the fix/minify-main-requirements branch May 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants