-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix geography filter on family search #257
Conversation
fa4a9c0
to
dcf8dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Would like the test I've commented on to be parametrized if possible - as the test code is essentially the same for both checks you're doing on Afghanistan and Zim :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!!
Description
The subquery pattern that was previously used was conflicting with the filter attached further down the file
Whilst doing this, I think I've got firm footing to get the rest of the muli-geo work in pretty quick.
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
How Has This Been Tested?
Screen.Recording.2024-12-02.at.16.57.57.mov