Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix geography filter on family search #257

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Conversation

jamesgorrie
Copy link
Contributor

@jamesgorrie jamesgorrie commented Nov 28, 2024

Description

  • uses a more standard join for Geography to fetch geographies on a family

The subquery pattern that was previously used was conflicting with the filter attached further down the file

Whilst doing this, I think I've got firm footing to get the rest of the muli-geo work in pretty quick.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

How Has This Been Tested?

  • integration test
  • locally
  • on staging
Screen.Recording.2024-12-02.at.16.57.57.mov

@jamesgorrie jamesgorrie requested a review from a team as a code owner November 28, 2024 17:27
@jamesgorrie jamesgorrie changed the title fix: fix geogrpahy filter on family search fix geogrpahy filter on family search Dec 2, 2024
@jamesgorrie jamesgorrie changed the title fix geogrpahy filter on family search fix geography filter on family search Dec 2, 2024
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Would like the test I've commented on to be parametrized if possible - as the test code is essentially the same for both checks you're doing on Afghanistan and Zim :)

Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@jamesgorrie jamesgorrie merged commit e70a063 into main Dec 3, 2024
11 checks passed
@jamesgorrie jamesgorrie deleted the fix-geography-filter branch December 3, 2024 12:57
@jamesgorrie
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants