Fix issue that requires multiple logout clicks #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done @annaCPR |
annaCPR
previously requested changes
Dec 3, 2024
| vi.runAllTimers() | ||
|
|
||
| // Assert | ||
| expect(mockLogout).toHaveBeenCalledTimes(1) |
There was a problem hiding this comment.
I also wonder if we could replace all these mocks with the fake API? have a look in the mocks directory.
There was a problem hiding this comment.
I think that's a fab idea, though I don't think we have a logout route in our API?
…s-sign-out-twice-to-actually-sign
PatFawbertMills
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Fix issue that requires multiple logout clicks
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
x