Feature/app 96 update admin frontend to support multigeographies #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2025 15:33
- also only display the multi geo selector for mcf corpora
|
added 4 commits
January 8, 2025 17:59
We want to have multi geographies for non legacy corporas - so i have added a variable which checks what the corpora is and renders the geographies multi selector and updates the payload accordinly
…ort-multigeographies
katybaulch
reviewed
Jan 9, 2025
… param to the search endpoint, so we werent retrieving any families related to the geography
|
drive by fix on the geographies filter after
|
added 4 commits
January 9, 2025 19:45
…ayload - to prevent things breaking
mcf documents also do not expect anything in the metadata, therefore adding in these values cause a 400
Even when role is marked as notRequired(), its nested fields (label and value) are still validated if the role object exists in the input.
The previous typing didnt really fit into what we were doing, so i have made it a bit more simpler to reflect what we are doing in the yup validation schema. it was just becoming too unecessarily complex, which added to the already complex yup validation was just hell
jamesgorrie
reviewed
Jan 13, 2025
jamesgorrie
approved these changes
Jan 13, 2025
odrakes-cpr
deleted the
feature/app-96-update-admin-frontend-to-support-multigeographies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Update the form to edit and create families with multiple geographies
Drivebys -
Fix incorrect geography param being passed to the search endpoint
Fix validation error on the document form suppressed
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
x