Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination bug #207

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix pagination bug #207

merged 2 commits into from
Jan 11, 2024

Conversation

olaughter
Copy link
Contributor

Because of the way the backend processes the limit and offset values we ended up only ever getting ten results (aka the value of limit), this this turns out to be because we limit in the vespa query and then limit again in the result. Switching instead to have a fixed vespa limit resolves this issue until we can move limits to the vespa query

Description

Please include:

  • a summary of the changes
  • links to any related issue/ticket
  • any additional relevant motivation and context
  • details of any dependency updates that are required for this change

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

Because of the way the backend processes the limit and offset values we
ended up only ever getting ten results (aka the value of limit), this
this turns out to be because we limit in the vespa query and then limit
again in the result. Switching instead to have a fixed vespa limit resolves
this issue until we can move limits to the vespa query
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent code - particularly that test 😛

@olaughter olaughter merged commit 9de373f into main Jan 11, 2024
2 checks passed
@olaughter olaughter deleted the fo-search-bug-2 branch January 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants