Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole database dump #208

Merged
merged 19 commits into from
Jan 16, 2024
Merged

Whole database dump #208

merged 19 commits into from
Jan 16, 2024

Conversation

katybaulch
Copy link
Contributor

@katybaulch katybaulch commented Jan 15, 2024

Description

IF we improve the structure of our CSV data download and automate the creation of it
THEN we can make it easier for users to analyse our data

Created new endpoint for whole database dump that will check S3 for the expected object key of the data dump file for the most recent ingest. If it doesn't already exist, generate it and upload it to S3. Return the CSV to the user to finish.

Useful context

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from diversemix January 15, 2024 17:32
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one or two minor things - all these can wait tho - let's get a first cut 🟠

@katybaulch katybaulch merged commit 6702d26 into main Jan 16, 2024
2 checks passed
@katybaulch katybaulch deleted the whole-database-dump branch January 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants