-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whole database dump #208
Merged
Merged
Whole database dump #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diversemix
reviewed
Jan 15, 2024
diversemix
reviewed
Jan 15, 2024
diversemix
reviewed
Jan 15, 2024
diversemix
reviewed
Jan 15, 2024
tests/unit/scripts/whole_database_dump/test_whole_database_dump.py
Outdated
Show resolved
Hide resolved
diversemix
reviewed
Jan 15, 2024
diversemix
reviewed
Jan 15, 2024
diversemix
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one or two minor things - all these can wait tho - let's get a first cut 🟠
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IF we improve the structure of our CSV data download and automate the creation of it
THEN we can make it easier for users to analyse our data
Created new endpoint for whole database dump that will check S3 for the expected object key of the data dump file for the most recent ingest. If it doesn't already exist, generate it and upload it to S3. Return the CSV to the user to finish.
Useful context
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist