-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pdct 1759 make backend config endpoint focused on corpora not #430
Merged
annaCPR
merged 15 commits into
main
from
feature/pdct-1759-make-backend-config-endpoint-focused-on-corpora-not
Jan 6, 2025
Merged
Feature/pdct 1759 make backend config endpoint focused on corpora not #430
annaCPR
merged 15 commits into
main
from
feature/pdct-1759-make-backend-config-endpoint-focused-on-corpora-not
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-focused-on-corpora-not
katybaulch
reviewed
Dec 19, 2024
katybaulch
reviewed
Dec 19, 2024
katybaulch
reviewed
Dec 19, 2024
katybaulch
reviewed
Dec 19, 2024
katybaulch
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some docstrings for your new functions (sorry 😢) but otherwise all good!
annaCPR
deleted the
feature/pdct-1759-make-backend-config-endpoint-focused-on-corpora-not
branch
January 6, 2025 14:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a new top-level corpus_types object to the /config response
update each corpus within the corpus_types object to include org ID and name
update count_by_category and total to count families per corpus (rather than org) and add to each corpus object in the response
update relevant tests to check for the new structure
Please include:
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist