Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the indent of saved jsons. #120

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Updating the indent of saved jsons. #120

merged 1 commit into from
Nov 14, 2023

Conversation

THOR300
Copy link
Collaborator

@THOR300 THOR300 commented Nov 14, 2023

This Pull Request:

  • Integrates a bug fix for the indent with which we save jsons to s3.
  • This was raised during the pipeline tests as the test data changed dramatically.

@THOR300 THOR300 requested a review from olaughter November 14, 2023 17:01
olaughter
olaughter approved these changes Nov 14, 2023
View reviewed changes
Copy link

@olaughter olaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@THOR300 THOR300 merged commit 235528f into main Nov 14, 2023
1 check passed
@THOR300 THOR300 deleted the bugfix/indent branch November 14, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaughter olaughter olaughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@THOR300 @olaughter