Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reformat the package inclusion to give users the actual src directory #124

Merged
merged 1 commit into from
Jul 9, 2024
Merged

reformat the package inclusion to give users the actual src directory #124

merged 1 commit into from
Jul 9, 2024

Conversation

harrisonpim
Copy link
Contributor

The previous PR included a packages section of the pyproject.toml which was incorrectly formatted.

Restructing this allows users to run eg

from navigator_document_parser.translator.translate import translate_parser_output

when navigator_document_parser is installed in their project

@harrisonpim harrisonpim requested a review from THOR300 July 9, 2024 14:45
THOR300
THOR300 reviewed Jul 9, 2024
View reviewed changes
pyproject.toml Show resolved Hide resolved
THOR300
THOR300 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrisonpim harrisonpim merged commit 89c17fb into main Jul 9, 2024
1 check passed
@harrisonpim harrisonpim deleted the make-package-installable branch July 9, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THOR300 THOR300 THOR300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrisonpim @THOR300