Skip to content

Adding test for vespa config #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Adding test for vespa config #71

merged 1 commit into from
Oct 26, 2023

Conversation

THOR300
Copy link
Contributor

@THOR300 THOR300 commented Oct 25, 2023

This Pull Request:

  • Adds a test to assert that the _get_vespa_config function works as expected. This was done as part of the pipeline / step functions debugging process.
  • Renames the vespa module to vespa_ as it was shadowing the vespa package name.

joel-wright
joel-wright approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@joel-wright joel-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good, just don't understand the module renaming

@THOR300 THOR300 requested a review from joel-wright October 25, 2023 15:45
@THOR300 THOR300 merged commit c1c5b55 into main Oct 26, 2023
@THOR300 THOR300 deleted the feature/assert-get-vespa-instance-fails-if-certs-arent-present branch October 26, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olaughter olaughter Awaiting requested review from olaughter

@joel-wright joel-wright Awaiting requested review from joel-wright

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@THOR300 @joel-wright