Feature/maps filterable by dataset #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnneIsARealProgrammerNow
approved these changes
Nov 19, 2024
I just decided to print it because it made it easier to debug when something goes wrong! |
|
Ah, one last thing: did you check if there are cases where the corpus type is None? Not sure if its relevant as I don't know how the SQL query handles None vs empty string |
|
there are 110 docs with a null corpus type name which I think is an error with that field – and I think I raised this to the text quality team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note i didn't add the dataset names to the titles as they'd be too long again!