Updated all dependencies except ember-data. Fixed hasmany relationships. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating from base code
…recation warning)
Conflicts: addon/serializers/application.js
…seem to be working fine here
…stead of an empty array
…er-parse-adapter into ember-data-1.13.8
… for an empty hasmany relationship
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to the adapter, serializer, tests, and dummy app. Everything except ember-data is up to date. The dummy app is working and all tests are passing.
I'm not completely sure about how hasmany relationships should be handled. The serializer is currently checking relationship.options to see if the relationship "type" is either an array or a relation. I changed it to use a relation by default, since an array is not technically a relationship.