-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install for callgrind runner docker image #2071
base: master
Are you sure you want to change the base?
Conversation
Criterion benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role. Caused by: |
Callgrind benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.Caused by: |
Hmm, the runner is now working. That error is actually an error in the benchmarks comparison application. I'll go poke at that. |
|
Criterion benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role. Caused by: |
Callgrind benchmark resultsError when comparing benchmarks: Couldn't find AWS credentials in environment, credentials file, or IAM role.Caused by: |
Description of Changes
It seems the cargo solver has chosen a crate that doesn't compile with the rustc version in our docker image. This image is only used for benchmarks, so rather than trying to change our iai-callgrind-runner fork, I'm just updating the rustc version in the image.
API and ABI breaking changes
None
Expected complexity level and risk
0
Testing
Going to run the updated actions yml on this branch to see if it works