add signature of datastore_update_bsatn
host call
#2102
Merged
+168
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds the ABI
datastore_update_bsatn
, defining the signature inbindings-sys
and in the host.However, the ABI is not used by the
bindings
crate (todo) and theInstanceEnv::update
method added also istodo!()
.This PR is opened so that we can discuss and decide on the ABI signature and semantics.
Some design choices made here:
insert
. This does have a minor adverse perf impact. If it turns that this is a problem, we can nix that. There are also avenues for optimizing sequence generation by e.g., storing a(ColList, Box<[SequenceId]>)
directly in aTable
to avoid going to theTableSchema
.API and ABI breaking changes
None.
Expected complexity level and risk
3, its not used yet, but we are deciding on a signature and ABI call semantics in this PR.
Testing
Nothing to test yet. This has not been integrated yet.