Don't actually try to connect to network in tests

clockworklabs · Oct 2, 2024 · 7062f68 · 7062f68
1 parent 00d2741
commit 7062f68
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/src/SpacetimeDBClient.cs b/src/SpacetimeDBClient.cs
@@ -11,9 +11,6 @@
 using SpacetimeDB.Internal;
 using SpacetimeDB.ClientApi;
 using Thread = System.Threading.Thread;
-using System.Runtime.CompilerServices;
-
-[assembly: InternalsVisibleTo("SpacetimeDB.Tests")]
 
 namespace SpacetimeDB
 {
@@ -180,6 +177,7 @@ struct PreProcessedMessage
         private readonly BlockingCollection<PreProcessedMessage> _preProcessedNetworkMessages =
             new(new ConcurrentQueue<PreProcessedMessage>());
 
+        internal static bool IsTesting;
         internal bool HasPreProcessedMessage => _preProcessedNetworkMessages.Count > 0;
 
         private readonly CancellationTokenSource _preProcessCancellationTokenSource = new();
@@ -582,23 +580,26 @@ internal void Connect(string? token, string uri, string addressOrName)
             }
 
             Log.Info($"SpacetimeDBClient: Connecting to {uri} {addressOrName}");
-            Task.Run(async () =>
+            if (!IsTesting)
             {
-                try
-                {
-                    await webSocket.Connect(token, uri, addressOrName, Address);
-                }
-                catch (Exception e)
+                Task.Run(async () =>
                 {
-                    if (connectionClosed)
+                    try
                     {
-                        Log.Info("Connection closed gracefully.");
-                        return;
+                        await webSocket.Connect(token, uri, addressOrName, Address);
                     }
+                    catch (Exception e)
+                    {
+                        if (connectionClosed)
+                        {
+                            Log.Info("Connection closed gracefully.");
+                            return;
+                        }
 
-                    Log.Exception(e);
-                }
-            });
+                        Log.Exception(e);
+                    }
+                });
+            }
         }
 
         private void OnMessageProcessCompleteUpdate(IEventContext eventContext, List<DbOp> dbOps)

diff --git a/tests~/SnapshotTests.cs b/tests~/SnapshotTests.cs
@@ -268,6 +268,8 @@ public async Task VerifyAllTablesParsed()
 
         Log.Current = new TestLogger(events);
 
+        DbConnection.IsTesting = true;
+
         var client =
             DbConnection.Builder()
             .WithUri("wss://spacetimedb.com")