Skip to content

Commit 881964d

Browse files
authored
Fix CI (#204)
## Description of Changes I don't know when or why this broke (or, rather, how it worked before), but we're installing .NET 7 but packing BSATN.Runtime that multi-targets .NET Standard 2.1 + .NET 8. The latter part, as you'd expect, fails on CI. ~~This change tells `dotnet pack` to only pack for .NET Standard 2.1 since that's the one we're interested in on the client - .NET 8 support is only for C# server modules.~~ _Narrator: that didn't work out._ This change bumps .NET SDK to 8.0 because I still don't know how it worked before with .NET 7, and this seems like the more sensible solution anyway. ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* ## Testsuite *If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.* SpacetimeDB branch name: master ## Testing *Write instructions for a test that you performed for this PR* - [ ] Describe a test for this PR that you have completed
1 parent 474f0d6 commit 881964d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/dotnet.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: Setup .NET
2121
uses: actions/setup-dotnet@v4
2222
with:
23-
dotnet-version: 7.0.x
23+
dotnet-version: 8.0.x
2424
- name: Checkout SpacetimeDB
2525
uses: actions/checkout@v4
2626
with:
@@ -29,7 +29,7 @@ jobs:
2929
- name: Setup SpacetimeDB packages
3030
working-directory: spacetimedb-csharp-sdk
3131
run: |
32-
( cd ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime && dotnet pack )
32+
dotnet pack ../SpacetimeDB/crates/bindings-csharp/BSATN.Runtime
3333
3434
# Write out the nuget config file to `nuget.config`. This causes the spacetimedb-csharp-sdk repository
3535
# to be aware of the local versions of the `bindings-csharp` packages in SpacetimeDB, and use them if

0 commit comments

Comments
 (0)