Conversation
RReverser
force-pushed
the
ingvar/unity-network-manager
branch
from
130479b to
e4ae059
Compare
This got broken when we switched to a new DbConnection API. Keep track of all the active connections and update/destroy them from a singleton game object. Fixes #134. Marked as a draft for now, because it's untested and because we're not yet sure that singleton for all connections as requested is the right approach.
RReverser
force-pushed
the
ingvar/unity-network-manager
branch
from
e4ae059 to
33ede79
Compare
No idea what I'm doing, just following what we did in the meeting.
jdetter
approved these changes
Oct 4, 2024
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I tested this myself and it works. My only nit here is that we really should rename this to something other than UnityNetworkManager. My recommendation would be SpacetimeDBNetworkManager even though it's a bit long.
generated meta files
…worklabs/com.clockworklabs.spacetimedbsdk into ingvar/unity-network-manager
bfops
added a commit
that referenced
this pull request
Oct 4, 2024
## Description of Changes Release these changes: ``` 2783385 0.12.0 DLLs (again) (#161) 7046408 Update to tests/examples follow codegen changes (#160) a7c720f Use SpacetimeDBNetworkManager everywhere (#157) 8916c18 Upgrade SDK Version to 0.12 (#156) b79d90c Fix UnityNetworkManager (#141) cff42fb Accept multiple queries in Subscribe (#153) 8f9614d Update DLLs for 0.12.0 (#152) 62a092e Jeremie/remove break (#154) ce76890 Try to catch flaky bugs (#150) 8ce9b7b Remove obsolete tools folder (#149) 19e8979 Fix `gen-client-api` scripts for new CLI API (#151) f04e2fd Add script to generate `nuget.config` (#115) f9c71c0 Don't actually try to connect to network in tests (#144) 00d2741 Reduce public API surface further (#145) 2bed3c3 Tighten package sources in C# smoketests (#133) 63e6f79 Fix UnityDebugLogger implementation (#143) 8df6d15 Implement websocket changes atop C# sdk changes (#136) 95b9d17 Hide more APIs (#140) 2aae961 Add DbConnection argument to OnConnect (#138) 0981b89 Merge table cache into table handle (#139) f8ddab7 Subscription API (#137) 7bef448 c# client SDK (DbConnection + SDK Callbacks) (#131) 65c97ad Logging API (#132) 7941798 Copy files from old repo (#127) 9904a02 Nix `Primitives.cs` - types now defined in main repo (#120) 5e612f3 Update DEVELOP.md to reflect new codegen (#119) ae7c531 Restore `dotnet pack` functionality (#118) 9481380 Don't use BuiltinType.I/U128, use AlgebraicType.I/U128 (#116) ``` ## API Almost certainly a breaking change ## Requires SpacetimeDB PRs Requires version 0.12.0 in SpacetimeDB --------- Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com> Co-authored-by: Jeremie Pelletier <jeremiep@gmail.com> Co-authored-by: Ingvar Stepanyan <me@rreverser.com> Co-authored-by: SteveGibson <100594800+SteveBoytsun@users.noreply.github.com> Co-authored-by: Steve Boytsun <steve@clockwokrlabs.io> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: John Detter <no-reply@boppygames.gg>
bfops
pushed a commit
that referenced
this pull request
Jul 28, 2025
This got broken when we switched to a new DbConnection API. Keep track of all the active connections and update/destroy them from a singleton game object. Fixes #134. Marked as a draft for now, because it's untested and because we're not yet sure that singleton for all connections as requested is the right approach. ## Description of Changes *Describe what has been changed, any new features or bug fixes* ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* --------- Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: John Detter <no-reply@boppygames.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken when we switched to a new DbConnection API.
Keep track of all the active connections and update/destroy them from a singleton game object. Fixes #134.
Marked as a draft for now, because it's untested and because we're not yet sure that singleton for all connections as requested is the right approach.
Description of Changes
Describe what has been changed, any new features or bug fixes
API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work