Regenerate SpacetimeDB ClientAPI bindings #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/regenerate-client-api-bindings
branch
from
6625591 to
dc4b38d
Compare
jdetter
force-pushed
the
jdetter/regenerate-client-api-bindings
branch
from
dc4b38d to
94f3506
Compare
jdetter
commented
Oct 3, 2024
| @@ -19,11 +18,11 @@ public partial class BsatnRowList | |||
| [DataMember(Name = "size_hint")] | |||
| public SpacetimeDB.ClientApi.RowSizeHint SizeHint; | |||
| [DataMember(Name = "rows_data")] | |||
| public byte[] RowsData; | |||
| public System.Collections.Generic.List<byte> RowsData; | |||
There was a problem hiding this comment.
hmmmm this is suspicious. @RReverser what do you think?
|
This must go into 0.12, without this PR this sdk doesn't build in Unity! |
jdetter
force-pushed
the
jdetter/regenerate-client-api-bindings
branch
from
0962e9a to
94f3506
Compare
|
closing in favor of something like this: #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Describe what has been changed, any new features or bug fixes
Staging has been broken in Unity since this PR merged: #116
The errors:
I believe the reason for this is out of date bindings for the ClientAPI. I've regenerated the bindings and it seems to be building now.
Follow-up actions
API
If the API is breaking, please state below what will break
Not breaking
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work
No PRs required
Testing