fix(202): RemoteQuery should not SELECT * #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
approved these changes
Jan 6, 2025
RReverser
force-pushed
the
joshua/fix/202/remote-query
branch
from
0f987ed to
10649ac
Compare
joshua-spacetime
force-pushed
the
joshua/fix/202/remote-query
branch
from
10649ac to
9dc0cb5
Compare
Fixes #202. Because SELECT * is ambiguous for join queries
joshua-spacetime
force-pushed
the
joshua/fix/202/remote-query
branch
from
9dc0cb5 to
397752d
Compare
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #202.
Because SELECT * is ambiguous if the query is a join
Description of Changes
Bug Fix
Previously
RemoteQuerywould implicitlySELECT *. This was wrong because you can useRemoteQueryto issue join queries.API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
List any PRs here that are required for this SDK change to work
Testsuite
If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.
SpacetimeDB branch name: v1.0.0-rc1
Testing
NOTE: This patch is untested. The risk is minimal given the simplicity of the fix. I looked for some example tests that I could extend, but didn't see anything applicable. Nevertheless it would still be useful to add a regression test.