Amend withCredentials to withToken
#128
Open
+6
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`withCredentials` was designed for our old auth model, where tokens were always issued by the SpacetimeDB host alongside an `Identity`, and therefore the bearer always knew their `Identity`. In our new auth model, a client may have a valid auth-able JWT but not know what `Identity` it will result in, as the `Identity` is computed based on the hash of some of the token's contents, and this hashing algorithm is not included in our client SDKs. As such, this PR revises `withCredentials` to `withToken`, which just accepts the token.
|
commit: |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
withCredentialswas designed for our old auth model, where tokens were always issued by the SpacetimeDB host alongside anIdentity, and therefore the bearer always knew theirIdentity.In our new auth model,
a client may have a valid auth-able JWT but not know what
Identityit will result in, as theIdentityis computed based on the hash of some of the token's contents, and this hashing algorithm is not included in our client SDKs. As such, this PR reviseswithCredentialstowithToken, which just accepts the token.API
See description.
Requires SpacetimeDB PRs
N/a
Testing
Completely untested.