Fix issue where some Typescript based project transpiler might mangle the table or Reducer #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drogus
approved these changes
Mar 12, 2024
|
@drogus I can see a new published version on npmjs (0.8.2) but the published files do not have the changes? Forgot to build? |
|
@hsreina I have released before I merged your commit, but I can cut a new release tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issues, /issues/31
This commit change the way the table and reducer are registered to prevent an error message like
Could not find class "Person", you need to register it with SpacetimeDBClient.registerTable() firstto happen.Some Typescript based project change the name of the classes when beging converted into javaScript. This behavior prevent the Tables and Reducer to be registered with the right name.
I used the name who are found in the auto generated TypeScript code.
reducer.reducerName for the reducer and table.tableName for the tables