Update class.AttachmentPreviewPlugin.php

[leandrovergara]

Added on elseif from line 1059 an extra validation in order to use this plugin in task issues.

[ilippert]

@leandrovergara, in my osticket, v.1.12 if I implement your change, I cannot access osticket anymore.

[leandrovergara]

Can you send me the error that you are having? Which version of AttachmentPreviewPlugin are you using?

[leandrovergara]

Hi Ingmar, Sorry i didn't answer your bug post. I was on Argentina Winter Holidays. I have already send you some questions in order to help you in your original comment. Please reply and i'll do my best in order to help you. Have a nice day. Leandro. El jue., 1 ago. 2019 a las 19:42, Ingmar Lippert (<[email protected]>) escribió:

…

would be great ifyour have time to review and merge this as the task functionality is otherwise well usable, @clonemeagain <https://github.com/clonemeagain> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40?email_source=notifications&email_token=AE6QA76MXSLXFISUYDS2DYTQCNRDRA5CNFSM4HNLNZYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3MCYGA#issuecomment-517483544>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE6QA75QPCLQALJ5RISLA63QCNRDRANCNFSM4HNLNZYA> .

-- Leandro H. Vergara

[ilippert]

Dear Leandro,

thanks for writing.

I used the plugin from https://codeload.github.com/clonemeagain/attachment_preview/zip/master

I did not experience an error beyond simply nothing showing at all. the apache log tells me

PHP Parse error: syntax error, unexpected '||' (T_BOOLEAN_OR)

The lines in the code look like this

  elseif (strpos($url, 'index.php') !== FALSE ||
  strpos($url, 'tickets.php') !== FALSE) ||
  strpos($url, 'tasks.php') !== FALSE) {
  // Might be a ticket or a task page.
  $tickets_view = TRUE;

Cheers, Ingmar

[clonemeagain]

Syntax error with this brace ), suggest removing it.

[ilippert]

whilst this suggested change does achieve not breaking the site, it does not yet achieve resulting in the equivalent collapsible boxes within the task views, as within the tickets.

[leandrovergara]

Change have been commited on branch. Please check again an tell me please.

[ilippert]

as mentioned earlier, this change does not break the system. however, it does not yet achieve actually showing the collapsible frames for the attachment within the task view. That is, the "Show Attachment" button is not shown.

[leandrovergara]

I don't use "Show Attachment" functionality, because most of attachment are pdf or images files, so i preview them on task inside the thread. Can you show me some example with a screenshot so i could help your issue?

[ilippert]

in a ticket view, I get this result:
https://ibb.co/4Kb9G7t

in a task I get this result:
https://ibb.co/8cczvSc

[clonemeagain]

We don't use tasks, but with the recent PR merge, this conflicts, so needs a touch of rework, apologies