-
Notifications
You must be signed in to change notification settings - Fork 149
Revisión de la práctica DASS01 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
a1c38df
9121a3b
b6dc09f
51a0c90
87a1fde
2bc1fda
63c412a
fab2ebd
28b9345
351f05c
4246606
089d527
8026e59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,18 +97,45 @@ public void testAcquireReusable() { | |
| */ | ||
| @Test | ||
| public void testReleaseReusable() throws NotFreeInstanceException { | ||
|
|
||
| try { | ||
| // se libera del pool un objeto reusable, correcto | ||
| pool.releaseReusable(reusable1); | ||
| //se libera del pool un objeto reusable, correcto | ||
| pool.releaseReusable(reusable2); | ||
| // se intenta liberar el mismo objeto reusable, | ||
| // DuplicatedInstanceException | ||
| pool.releaseReusable(reusable1); | ||
| fail("Se esperaba excepci�n de tipo DuplicatedInstanceException"); | ||
|
||
|
|
||
| } catch (DuplicatedInstanceException e) { | ||
| assertEquals("Ya existe esa instancia en el pool.", e.getMessage()); | ||
| } catch (Exception e) { | ||
| fail("No se espera ninguna excepcion"); | ||
| } | ||
|
|
||
| // se a�ade el objeto reusable para dejar el pool vacio (estado inicial) | ||
|
|
||
|
||
| try { | ||
| //se intenta liberar un objeto nulo, Excepcion | ||
| pool.releaseReusable(null); | ||
| fail("Se esperaba excepci�n de tipo Exception que controle la liberaci�n de nulos"); | ||
|
||
| }catch (Exception e){ | ||
|
||
| assertEquals("No se puede liberar un objeto nulo", e.getMessage()); | ||
|
||
| } | ||
|
|
||
| try{ | ||
| //se intenta liberar un objeto reusable, cuando ya esta completo el pool | ||
| Reusable reusable3=new Reusable(); | ||
| pool.releaseReusable(reusable3); | ||
| fail("Se esperaba excepci�n de tipo Exception que controle la dimensi�n m�xima del pool"); | ||
|
||
| }catch(Exception e){ | ||
| assertEquals("No se puede liberar mas objetos que la dimension del pool", e.getMessage()); | ||
|
|
||
| } | ||
|
|
||
| // se a�ade los objetos reusables para dejar el pool vacio (estado inicial) | ||
| reusable1 = pool.acquireReusable(); | ||
| reusable2 = pool.acquireReusable(); | ||
|
|
||
| } | ||
|
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
El método implementa múltiples casos de prueba.
Mejor crear un método por cada uno de los casos de prueba.
El nombre de los nuevos métodos puede ser testReleaseReusablexx, donde xx se corresponden con dos dígitos decimales que ayuden a identificar el caso de prueba en la documentación.